Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update copyright year for all files to 2025 + run moon fmt #1460

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

mindreframer
Copy link
Contributor

Just to make sure the copyright year is consistent.

Thanks for making MoonBit, it's a joy to use!
Roman

Copy link

peter-jerry-ye-code-review bot commented Jan 11, 2025

‼️ This code review is generated by a bot. Please verify the content before trusting it.

The git diff output provided shows changes across multiple files, primarily updating the copyright year from 2024 to 2025. Here are three observations and potential issues:

  1. Copyright Year Update:

    • The primary change across all files is updating the copyright year from 2024 to 2025. This is a routine update and does not indicate any functional issues or bugs. However, it's important to ensure that this change is consistent across all files, which appears to be the case here.
  2. Typo in Comment:

    • In the file builtin/linked_hash_map.mbt, there is a typo in the comment: // overflow happend should be corrected to // overflow happened. This is a minor issue but should be fixed for clarity and correctness.
  3. CR Comment in Priority Queue:

    • In the file priority_queue/priority_queue.mbt, there are comments marked with // CR: bad formatting. These comments suggest that there are formatting issues in the code that need to be addressed. Specifically, the formatting of the T::from_array and T::of functions should be reviewed and corrected for better readability and consistency.

These are the key observations from the provided git diff output. The changes are mostly routine updates, but there are minor issues like typos and formatting comments that should be addressed.

@mindreframer mindreframer force-pushed the chore/update-copyright-year branch from 95490f1 to 166a8f4 Compare January 11, 2025 23:25
@coveralls
Copy link
Collaborator

coveralls commented Jan 11, 2025

Pull Request Test Coverage Report for Build 4708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 82.922%

Files with Coverage Reduction New Missed Lines %
builtin/iter2.mbt 1 70.0%
Totals Coverage Status
Change from base Build 4704: 0.0%
Covered Lines: 4768
Relevant Lines: 5750

💛 - Coveralls

@bobzhang bobzhang merged commit d96f0ad into moonbitlang:main Jan 12, 2025
14 checks passed
@bobzhang
Copy link
Contributor

@mindreframer thank you for nice words!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants